Skip to content

Conversation

@dtfranz
Copy link
Contributor

@dtfranz dtfranz commented Sep 12, 2024

Also simplifies the verify github action.

Background: #1240 (comment)

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@dtfranz dtfranz requested a review from a team as a code owner September 12, 2024 22:34
@netlify
Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit b677be6
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66e36d337cf1880008cb690d
😎 Deploy Preview https://deploy-preview-1266--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Also simplifies the verify github action.

Signed-off-by: dtfranz <[email protected]>
@dtfranz dtfranz force-pushed the catalogd-api-ref-gen-cleanup branch from 926e8df to b677be6 Compare September 12, 2024 22:37
@codecov
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.51%. Comparing base (3e2a884) to head (b677be6).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1266      +/-   ##
==========================================
+ Coverage   76.47%   76.51%   +0.04%     
==========================================
  Files          40       40              
  Lines        2363     2363              
==========================================
+ Hits         1807     1808       +1     
+ Misses        390      389       -1     
  Partials      166      166              
Flag Coverage Δ
e2e 57.85% <ø> (ø)
unit 53.06% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@everettraven everettraven added this pull request to the merge queue Sep 13, 2024
Merged via the queue into operator-framework:main with commit 188858c Sep 13, 2024
17 checks passed
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants