Skip to content

Conversation

joelanford
Copy link
Member

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@joelanford joelanford requested a review from a team as a code owner September 16, 2024 20:47
Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 0009c86
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66e8994ea9cc86000827b402
😎 Deploy Preview https://deploy-preview-1275--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.51%. Comparing base (f0c761d) to head (0009c86).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1275   +/-   ##
=======================================
  Coverage   76.51%   76.51%           
=======================================
  Files          40       40           
  Lines        2363     2363           
=======================================
  Hits         1808     1808           
  Misses        389      389           
  Partials      166      166           
Flag Coverage Δ
e2e 57.85% <ø> (ø)
unit 53.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joelanford joelanford added this pull request to the merge queue Sep 17, 2024
Merged via the queue into operator-framework:main with commit e16eb76 Sep 17, 2024
19 checks passed
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
@joelanford joelanford deleted the golangci-lint-fixes branch October 22, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants