Skip to content

Conversation

bentito
Copy link
Contributor

@bentito bentito commented Sep 16, 2024

Expanded the documentation to include detailed steps on downgrading a ClusterExtension, including disabling CRD safety checks and overriding upgrade constraints. Added prerequisites, troubleshooting, and post-downgrade verification sections.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Significantly expanded the documentation to include detailed steps on downgrading a ClusterExtension, including disabling CRD safety checks and overriding upgrade constraints. Added prerequisites, troubleshooting, and post-downgrade verification sections.

Signed-off-by: Brett Tofel <[email protected]>
@bentito bentito requested a review from a team as a code owner September 16, 2024 21:14
@netlify
Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 220ec73
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66e9ac5e9a7521000804589b
😎 Deploy Preview https://deploy-preview-1277--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bentito
Copy link
Contributor Author

bentito commented Sep 17, 2024

fixes #1229

@codecov
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.51%. Comparing base (33f6abf) to head (220ec73).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1277   +/-   ##
=======================================
  Coverage   76.51%   76.51%           
=======================================
  Files          40       40           
  Lines        2363     2363           
=======================================
  Hits         1808     1808           
  Misses        389      389           
  Partials      166      166           
Flag Coverage Δ
e2e 57.85% <ø> (ø)
unit 53.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


## Introduction

Downgrading a `ClusterExtension` involves reverting the extension to a previous available version. This process might be required due to compatibility issues, unexpected behavior in the newer version, or specific feature requirements that are only available in an earlier release. This guide provides step-by-step instructions to safely downgrade a `ClusterExtension`, including necessary overrides to bypass default constraints and disable CRD safety checks.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a bit of an aversion to saying that this guide will help you downgrade "safely". IMO, performing a downgrade with the type of software we are managing with OLM is inherently an "unsafe" operation. While it may not always be the case, my assumption would be that a user runs the risk of data loss, invalidation of anything stored at new CRD versions, and potentially break clients that expect the newer version to be running. Before doing a downgrade, users should be confident that they want to do it and that they understand and have considered the potential consequences of performing a downgrade.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's fair. I have reworded the intro entirely, incorporating your feedback. Thanks!

Enhanced downgrade guide with new risks and update steps. Replaced manual `kubectl edit` step with a `kubectl patch` command for disabling CRD safety checks.

Signed-off-by: Brett Tofel <[email protected]>
@everettraven everettraven added this pull request to the merge queue Sep 17, 2024
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2024
Merged via the queue into operator-framework:main with commit 11c590c Sep 17, 2024
18 checks passed
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants