🌱 Fix http.DefaultClient
#1278
Merged
🌱 Fix http.DefaultClient
#1278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not want to modify `http.DefaultClient` because it can cause undesired effects in other places. Signed-off-by: Mikalai Radchuk <[email protected]>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1278 +/- ##
==========================================
- Coverage 76.51% 76.47% -0.05%
==========================================
Files 40 40
Lines 2363 2363
==========================================
- Hits 1808 1807 -1
- Misses 389 390 +1
Partials 166 166
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/lgtm |
joelanford
approved these changes
Sep 17, 2024
Merged
via the queue into
operator-framework:main
with commit Sep 17, 2024
06424ef
17 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We do not want to modify
http.DefaultClientbecause it can cause undesired effects in other places. It is not an issue right now since we only use the default client in one place, but can become an issue if we introduce usage in another piece of code: there is a chance (depending on the ordering) that some other test will be usingTransportfrom another test. It is best to create a new instance of a client so we do not re-use the state.Reviewer Checklist