Skip to content

Conversation

@michaelryanpeter
Copy link
Contributor

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@michaelryanpeter michaelryanpeter requested a review from a team as a code owner September 20, 2024 15:40
@netlify
Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 04ff215
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66ed978b0e2c5400082db52b
😎 Deploy Preview https://deploy-preview-1290--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.60%. Comparing base (a752f58) to head (04ff215).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1290   +/-   ##
=======================================
  Coverage   76.60%   76.60%           
=======================================
  Files          40       40           
  Lines        2406     2406           
=======================================
  Hits         1843     1843           
  Misses        395      395           
  Partials      168      168           
Flag Coverage Δ
e2e 58.14% <ø> (ø)
unit 53.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ^^

Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2024
@everettraven everettraven added this pull request to the merge queue Sep 20, 2024
Merged via the queue into operator-framework:main with commit 62b5c53 Sep 20, 2024
18 checks passed
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants