Skip to content

Conversation

dtfranz
Copy link
Contributor

@dtfranz dtfranz commented Oct 17, 2024

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2024
@netlify
Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for olmv1 failed.

Name Link
🔨 Latest commit 2e386e4
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67115df0f337350008e3bb34

@codecov
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.25%. Comparing base (79f42d5) to head (2e386e4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1389      +/-   ##
==========================================
- Coverage   74.84%   73.25%   -1.59%     
==========================================
  Files          42       42              
  Lines        2516     3159     +643     
==========================================
+ Hits         1883     2314     +431     
- Misses        449      659     +210     
- Partials      184      186       +2     
Flag Coverage Δ
e2e 54.73% <ø> (-2.03%) ⬇️
unit 52.64% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: dtfranz <[email protected]>
@dtfranz
Copy link
Contributor Author

dtfranz commented Oct 18, 2024

Seems to be working again

@dtfranz dtfranz closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant