Skip to content

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Oct 25, 2024

Description

Some dependencies start requiring newer version of Python. MarkupSafe is an example: #1399

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2024
@netlify
Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 9c822c1
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/671b63fc435ce300085af336
😎 Deploy Preview https://deploy-preview-1408--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@m1kola m1kola marked this pull request as ready for review October 25, 2024 09:26
@m1kola m1kola requested a review from a team as a code owner October 25, 2024 09:26
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2024
@codecov
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.54%. Comparing base (07ed131) to head (9c822c1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1408      +/-   ##
==========================================
- Coverage   73.57%   73.54%   -0.04%     
==========================================
  Files          42       42              
  Lines        3194     3194              
==========================================
- Hits         2350     2349       -1     
- Misses        659      660       +1     
  Partials      185      185              
Flag Coverage Δ
e2e 55.13% <ø> (ø)
unit 53.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2024
@m1kola m1kola added this pull request to the merge queue Oct 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 28, 2024
@m1kola m1kola added this pull request to the merge queue Oct 28, 2024
Merged via the queue into operator-framework:main with commit d1409d9 Oct 28, 2024
16 of 17 checks passed
@m1kola m1kola deleted the bump_python_deps branch October 28, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants