🌱 Loosen certificate checks #1413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The checks we had were a bit too constrained, and don't follow the golang standard library code. So, replace our replacement functions with the originals. This level of checking (e.g. mistyping a path) is not really necessary when people are using our (e.g. cert-manager) manifests. Signed-off-by: Todd Short <[email protected]>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1413 +/- ##
==========================================
- Coverage 73.38% 73.11% -0.28%
==========================================
Files 42 42
Lines 3194 3057 -137
==========================================
- Hits 2344 2235 -109
+ Misses 663 647 -16
+ Partials 187 175 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joelanford
approved these changes
Oct 29, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checks we had were a bit too constrained, and don't follow the golang standard library code. So, replace our replacement functions with the originals.
This level of checking (e.g. mistyping a path) is not really necessary when people are using our (e.g. cert-manager) manifests.
Description
Reviewer Checklist