🌱 feat: Prioritize Global kind Installation Over BINGO-Managed Version #1481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
camilamacedo86
force-pushed
the
use-global-kind
branch
from
f766d61 to
e16d5d2
Compare
camilamacedo86
changed the title
…ritizing the globally installed `kind` binary for managing Kubernetes clusters. It reduces potential conflicts and debugging issues, ensuring better compatibility with existing setups. 1. **Image Loading Issues**: - Using a BINGO-installed `kind` binary caused images to load into the wrong cluster, leading to debugging delays. 2. **Hidden Clusters**: - Clusters created with the BINGO-managed `kind` were not visible in the global `kind` context, causing resource leaks and confusion. - Check for a globally installed `kind` binary and use it if available. - Fallback to the BINGO-managed `kind` binary only when no global version is detected. - Provide clear messaging about the binary being used. - Respects developers' preferences and existing environments. - Prevents unnecessary debugging and resource leaks. - Aligns with standard workflows while maintaining BINGO compatibility.
camilamacedo86
force-pushed
the
use-global-kind
branch
from
e16d5d2 to
16923f6
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
camilamacedo86
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1481 +/- ##
=======================================
Coverage 74.73% 74.73%
=======================================
Files 42 42
Lines 3241 3241
=======================================
Hits 2422 2422
Misses 646 646
Partials 173 173
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
camilamacedo86
requested review from
bentito,
joelanford,
m1kola and
perdasilva
camilamacedo86
changed the title
m1kola
reviewed
Nov 19, 2024
|
Hi @m1kola
It worked locally. But if it is autogenerated, it will be lost |
|
Closing this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change respects developers' environments and preferences by prioritizing the globally installed
kindbinary for managing Kubernetes clusters. It reduces potential conflicts and debugging issues, ensuring better compatibility with existing setups.Scenarios Addressed
kindbinary caused images to load into the wrong cluster, leading to debugging delays.kindwere not visible in the globalkindcontext, causing resource leaks and confusion.Proposed Solution
kindbinary and use it if available.kindbinary only when no global version is detected.Benefits