🌱 [WIP]Monorepo #1531

LalatenduMohanty · 2024-12-19T14:54:34Z

Description

This is a WIP pr generated from the output of the monorepo migration script.

Reviewer Checklist

API Go Documentation
Tests: Unit Tests (and E2E Tests, if appropriate)
Comprehensive Commit Messages
Links to related GitHub Issue(s)

Signed-off-by: Joe Lanford <[email protected]>

Signed-off-by: Mikalai Radchuk <[email protected]>

Signed-off-by: Bryce Palmer <[email protected]>

…rk#91) Signed-off-by: Rashmi Gottipati <[email protected]>

Signed-off-by: Catherine Chan-Tse <[email protected]>

Update README Issue: operator-framework#81 Fix output examples Signed-off-by: Michael Ryan Peter <[email protected]>

…#103) Signed-off-by: Mikalai Radchuk <[email protected]>

Signed-off-by: Mikalai Radchuk <[email protected]>

…ork#109) Ideally, we would enforce restricted. However, some catalog images may not be compatible with restriced enforcement. This is another motivation for us to treat catalog images differently from runnable images. PSA compatibility of catalog images should never be a consideration because we only need to extract static files from them. Actually running them should never be necessary. Signed-off-by: Joe Lanford <[email protected]>

…edence if set (operator-framework#110) Signed-off-by: Joe Lanford <[email protected]>

Signed-off-by: dtfranz <[email protected]>

…#112) to ensure we only list resources belonging to the `Catalog` resource currently being reconciled. Signed-off-by: Bryce Palmer <[email protected]>

Fix link and misspelling The operator-controller docs link was 404ing, now it links to the correct folder. Signed-off-by: Justin Kulikauskas <[email protected]>

Signed-off-by: Andy Goldstein <[email protected]>

We do not want to fail the job if codecov fails to upload the report due to rate limiting. Signed-off-by: Mikalai Radchuk <[email protected]>

Signed-off-by: Andy Goldstein <[email protected]>

…ator-framework#138)

Signed-off-by: Andy Goldstein <[email protected]>

Marking the CatalogMetadataAPI feature gate as Deprecated before introducing the HTTP server as a default mechanism to serve catalog contents Signed-off-by: Rashmi Gottipati <[email protected]>

Signed-off-by: Joe Lanford <[email protected]>

closes operator-framework#113 Signed-off-by: Anik <[email protected]>

…mework#475) Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.9.0 to 1.10.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.9.0...v1.10.0) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…k#471) * (ci): add verify-crd-compatibility make target and GHA using the crd-diff tool with the same configuration as recently merged into operator-controller Signed-off-by: everettraven <[email protected]> * improve local developer experience Signed-off-by: everettraven <[email protected]> --------- Signed-off-by: everettraven <[email protected]>

…rk#477) Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.36.0 to 1.36.1. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.36.0...v1.36.1) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

) Bumps the k8s-dependencies group with 6 updates: | Package | From | To | | --- | --- | --- | | [k8s.io/api](https://github.com/kubernetes/api) | `0.31.3` | `0.31.4` | | [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.31.3` | `0.31.4` | | [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.31.3` | `0.31.4` | | [k8s.io/apiserver](https://github.com/kubernetes/apiserver) | `0.31.3` | `0.31.4` | | [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.31.3` | `0.31.4` | | [k8s.io/component-base](https://github.com/kubernetes/component-base) | `0.31.3` | `0.31.4` | Updates `k8s.io/api` from 0.31.3 to 0.31.4 - [Commits](kubernetes/api@v0.31.3...v0.31.4) Updates `k8s.io/apiextensions-apiserver` from 0.31.3 to 0.31.4 - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](kubernetes/apiextensions-apiserver@v0.31.3...v0.31.4) Updates `k8s.io/apimachinery` from 0.31.3 to 0.31.4 - [Commits](kubernetes/apimachinery@v0.31.3...v0.31.4) Updates `k8s.io/apiserver` from 0.31.3 to 0.31.4 - [Commits](kubernetes/apiserver@v0.31.3...v0.31.4) Updates `k8s.io/client-go` from 0.31.3 to 0.31.4 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.31.3...v0.31.4) Updates `k8s.io/component-base` from 0.31.3 to 0.31.4 - [Commits](kubernetes/component-base@v0.31.3...v0.31.4) --- updated-dependencies: - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies - dependency-name: k8s.io/apiextensions-apiserver dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies - dependency-name: k8s.io/apiserver dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies - dependency-name: k8s.io/component-base dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.28.0 to 0.31.0. - [Commits](golang/crypto@v0.28.0...v0.31.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: Joe Lanford <[email protected]>

Depending on how the e2e is run, we may not have a k8s client available. Signed-off-by: Todd Short <[email protected]>

dependabot updated go.mod, but didn't know about bingo Signed-off-by: Todd Short <[email protected]>

…r-framework#484) Ensure HTTP/2 is disabled by default for webhooks. Disabling HTTP/2 mitigates vulnerabilities associated with: - HTTP/2 Stream Cancellation (GHSA-qppj-fm5r-hxr3) - HTTP/2 Rapid Reset (GHSA-4374-p667-p6c8) While CVE fixes exist, they remain insufficient; disabling HTTP/2 helps reduce risks. For details, see: kubernetes/kubernetes#121197

netlify · 2024-12-19T14:55:22Z

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	`ca1923d`
🔍 Latest deploy log	https://app.netlify.com/sites/olmv1/deploys/677bfc6d961d2d0008f16f58
😎 Deploy Preview	https://deploy-preview-1531--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Lalatendu Mohanty <[email protected]>

joelanford · 2024-12-20T22:02:24Z

Unsurprisingly, CI is a mess. Is there a concerted effort to hunt down and fix all the CI issues so we can turn this green as soon as possible?

LalatenduMohanty · 2024-12-20T22:40:57Z

Unsurprisingly, CI is a mess. Is there a concerted effort to hunt down and fix all the CI issues so we can turn this green as soon as possible?

@joelanford We will look in to these first week of January and would be able able to fix these. Currently most of the folks are PTO for the year end holidays.

LalatenduMohanty · 2024-12-20T22:42:46Z

Also the individual tasks we are working on are not complete and I expect some of the tests to start passing once these tasks are done.

joelanford · 2024-12-21T01:36:34Z

Of course! I'm going to be gone for two weeks, too. Everyone should definitely take the time to recharge!

For when folks are back looking at this, I do wonder if we are complicating things and trying to do too much at once. What if we had a series of PRs:

Change just operator-controller to:
- move everything except .github down a level to a new folder called "operator-controller"
- in the .github/workflows folder prefix all files with operator-controller-, and update all workflows to first cd into operator-controller
- update any other tasks that look for files in the repo root by default (maybe bingo or goreleaser?)
Change just catalogd (in its repo) to do the exact same thing.

After (1) and (2) are complete, catalogd should be able to be easily overlaid into operator-controller, with only a few potential conflicts on the other files in the .github directory, and a replaces line in operator-controller's go.mod to point to ../catalogd.

From there, we could then have incremental PRs that start combining everything back down into a single root (if so desired). Or maybe we decide we like the separation and we instead go for a go.work setup with a Go workspace at the root.

camilamacedo86 · 2025-01-02T10:05:52Z

HI @joelanford and @LalatenduMohanty

See that I did what @LalatenduMohanty was trying to do here: #1540 and I follow your idea to rename the github actions by adding the pre-fix for catalogd.

Also, all CI checks are passing for both now, catalogd and operator-controller

Signed-off-by: Lalatendu Mohanty <[email protected]>

openshift-merge-robot · 2025-01-08T05:28:32Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

camilamacedo86 · 2025-01-09T20:11:46Z

@LalatenduMohanty, I think we can close this one
So, I hope that you do not mind I am moving forward now that we merged https://github.com/operator-framework/operator-controller/pulls?q=is%3Apr+is%3Aclosed

LalatenduMohanty · 2025-01-09T20:53:37Z

/close

joelanford and others added 30 commits June 7, 2023 17:31

bundlemetadata: make related images and properties optional

b21919d

Signed-off-by: Joe Lanford <[email protected]>

Add feature gates infrastructure (operator-framework#90)

9fe45a6

Adds error checking for feature gates (operator-framework#98)

83da08b

Signed-off-by: Mikalai Radchuk <[email protected]>

(ci): add linting + fix existing errors (operator-framework#99)

748a2a4

Signed-off-by: Bryce Palmer <[email protected]>

Implement CatalogMetadata API to expose FBC content (operator-framewo…

2365db6

…rk#91) Signed-off-by: Rashmi Gottipati <[email protected]>

bump to go 1.20 (operator-framework#101)

b46bc46

Update enhancement hackmd link (operator-framework#102)

fb12499

Signed-off-by: Catherine Chan-Tse <[email protected]>

operator-framework#81 Updated README (operator-framework#93)

d5ce2b1

Update README Issue: operator-framework#81 Fix output examples Signed-off-by: Michael Ryan Peter <[email protected]>

bump controller-gen to v0.12.0 (operator-framework#105)

225275d

Updates GH Actions to avoid using deprecated node (operator-framework…

52e8822

…#103) Signed-off-by: Mikalai Radchuk <[email protected]>

Adds codecov integration (operator-framework#104)

b996f69

Signed-off-by: Mikalai Radchuk <[email protected]>

e2e: support env var for catalog image (operator-framework#108)

c691c3e

detect in-cluster namespace by default, --system-namespace takes prec…

680aefa

…edence if set (operator-framework#110) Signed-off-by: Joe Lanford <[email protected]>

Remove Resource Limits (operator-framework#111)

3b1780e

Signed-off-by: dtfranz <[email protected]>

(bugfix): add label selector to sync list queries (operator-framework…

7a98e45

…#112) to ensure we only list resources belonging to the `Catalog` resource currently being reconciled. Signed-off-by: Bryce Palmer <[email protected]>

(docs) Fix link and misspelling (operator-framework#122)

61810e2

Fix link and misspelling The operator-controller docs link was 404ing, now it links to the correct folder. Signed-off-by: Justin Kulikauskas <[email protected]>

Add initial Tilt support

caad7f1

Signed-off-by: Andy Goldstein <[email protected]>

Makes codecov-action optional

bb7e825

We do not want to fail the job if codecov fails to upload the report due to rate limiting. Signed-off-by: Mikalai Radchuk <[email protected]>

Enable dependabot (operator-framework#125)

ae01ba3

Signed-off-by: Andy Goldstein <[email protected]>

Enable merge queue (operator-framework#131)

823972c

Signed-off-by: Andy Goldstein <[email protected]>

Switch to using tilt-support repo

442b6a9

Signed-off-by: Andy Goldstein <[email protected]>

Add DCO information

8a5e079

Signed-off-by: Andy Goldstein <[email protected]>

Add CI for tilt (operator-framework#134)

64a9fe5

Signed-off-by: Andy Goldstein <[email protected]>

Enable CatalogMetadataAPI via explicit flag, fix syncing issues (oper…

f1067da

…ator-framework#138)

Setup CODEOWNERS (#140)

1a81219

Signed-off-by: Andy Goldstein <[email protected]>

Deprecate the CatalogMetadataAPI feature gate (operator-framework#141)

a8f7196

Marking the CatalogMetadataAPI feature gate as Deprecated before introducing the HTTP server as a default mechanism to serve catalog contents Signed-off-by: Rashmi Gottipati <[email protected]>

Remove Package and BundleMetadata APIs (operator-framework#149)

8aab690

Signed-off-by: Joe Lanford <[email protected]>

add go-apidiff action (operator-framework#151)

cd2c38d

Signed-off-by: Joe Lanford <[email protected]>

Store FBC in local directory (operator-framework#144)

04d3828

closes operator-framework#113 Signed-off-by: Anik <[email protected]>

dependabot bot and others added 10 commits November 28, 2024 07:23

gha: release: only push images for main branch (operator-framework#481)

e2d3b56

Signed-off-by: Joe Lanford <[email protected]>

e2e: add tests to verify metrics endpoint (operator-framework#483)

f91558f

Add check for client in e2e (operator-framework#485)

0dbef9b

Depending on how the e2e is run, we may not have a k8s client available. Signed-off-by: Todd Short <[email protected]>

Update bingo's ginkgo to v2.22.0 (operator-framework#486)

4590ca5

dependabot updated go.mod, but didn't know about bingo Signed-off-by: Todd Short <[email protected]>

LalatenduMohanty requested a review from a team as a code owner December 19, 2024 14:54

Monorepo prep commit

5bfc1f7

Signed-off-by: Lalatendu Mohanty <[email protected]>

camilamacedo86 mentioned this pull request Jan 2, 2025

WIP TESTING #1540

Closed

LalatenduMohanty added 5 commits January 6, 2025 10:51

Update catalogd API v1 imports

c6eb190

Signed-off-by: Lalatendu Mohanty <[email protected]>

Merge catalogd/monorepo_prep branch into operator-controller

cbfe01d

Signed-off-by: Lalatendu Mohanty <[email protected]>

Remove redundant catalogd import

48a0694

Signed-off-by: Lalatendu Mohanty <[email protected]>

Update go.mod location in catalogd/Makefile

506d2fa

Signed-off-by: Lalatendu Mohanty <[email protected]>

Check in generated manifest files

ca1923d

Signed-off-by: Lalatendu Mohanty <[email protected]>

LalatenduMohanty force-pushed the monorepo branch from 7bb3d58 to ca1923d Compare January 6, 2025 15:53

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 8, 2025

camilamacedo86 closed this Jan 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

🌱 [WIP]Monorepo #1531

🌱 [WIP]Monorepo #1531

Uh oh!

LalatenduMohanty commented Dec 19, 2024 •

edited by oceanc80

Loading

Uh oh!

netlify bot commented Dec 19, 2024 •

edited

Loading

Uh oh!

joelanford commented Dec 20, 2024

Uh oh!

LalatenduMohanty commented Dec 20, 2024 •

edited

Loading

Uh oh!

LalatenduMohanty commented Dec 20, 2024

Uh oh!

joelanford commented Dec 21, 2024

Uh oh!

camilamacedo86 commented Jan 2, 2025

Uh oh!

openshift-merge-robot commented Jan 8, 2025

Uh oh!

camilamacedo86 commented Jan 9, 2025

Uh oh!

LalatenduMohanty commented Jan 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

22 participants

🌱 [WIP]Monorepo #1531

🌱 [WIP]Monorepo #1531

Uh oh!

Conversation

LalatenduMohanty commented Dec 19, 2024 • edited by oceanc80 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Reviewer Checklist

Uh oh!

netlify bot commented Dec 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for olmv1 ready!

Uh oh!

joelanford commented Dec 20, 2024

Uh oh!

LalatenduMohanty commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LalatenduMohanty commented Dec 20, 2024

Uh oh!

joelanford commented Dec 21, 2024

Uh oh!

camilamacedo86 commented Jan 2, 2025

Uh oh!

openshift-merge-robot commented Jan 8, 2025

Uh oh!

camilamacedo86 commented Jan 9, 2025

Uh oh!

LalatenduMohanty commented Jan 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

22 participants

LalatenduMohanty commented Dec 19, 2024 •

edited by oceanc80

Loading

netlify bot commented Dec 19, 2024 •

edited

Loading

LalatenduMohanty commented Dec 20, 2024 •

edited

Loading