-
Notifications
You must be signed in to change notification settings - Fork 67
🌱 Replace Depecated Action to validate the PR Title with script #1541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Replace Depecated Action to validate the PR Title with script #1541
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The action is deprecated and goes away when Kubebuilder GCP Project no longer be available. Therefore, this PR replaces the action for the shell script that does the same check. More info: https://github.com/kubernetes-sigs/kubebuilder-release-tools?tab=readme-ov-file#pr-verification-github-action-deprecated
22a3a36
to
bfa0c03
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1541 +/- ##
==========================================
- Coverage 74.25% 74.22% -0.04%
==========================================
Files 42 42
Lines 3329 3329
==========================================
- Hits 2472 2471 -1
- Misses 676 677 +1
Partials 181 181
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -0,0 +1,50 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering if something like:
if ! [[ $pr-title =~ ^[🌱⚠ ... ] ]]; then
...
fi
would be enough...
do we want to post success for [WIP] 🌱 ... ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are still failing when WIP is
The rules ,I think would still the same: kubernetes-sigs/[email protected]
@joe suggested we create an action there in the repo as well
I just had no effort to maintain the kubebuilder-release-tools
But let's put it in
/hold
I will see if I can change there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it real quick and it seems to let [WIP] titles through:
./hack/test/pr-title.sh "[WIP] 🌱 Replace Depecated Action to validate the PR Title with script"
PR title is valid: 🌱 Replace Depecated Action to validate the PR Title with script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we just fork the action repo and use that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean to start to maintain that inside of operator-framework?
I will close for now. If needed, I reopen this one. |
The action is deprecated and goes away when Kubebuilder GCP Project no longer be available. Therefore, this PR replaces the action for the shell script that does the same check. More info: https://github.com/kubernetes-sigs/kubebuilder-release-tools?tab=readme-ov-file#pr-verification-github-action-deprecated
Description
Reviewer Checklist