Skip to content

Conversation

camilamacedo86
Copy link
Contributor

The action is deprecated and goes away when Kubebuilder GCP Project no longer be available. Therefore, this PR replaces the action for the shell script that does the same check. More info: https://github.com/kubernetes-sigs/kubebuilder-release-tools?tab=readme-ov-file#pr-verification-github-action-deprecated

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@camilamacedo86 camilamacedo86 requested a review from a team as a code owner January 2, 2025 16:40
Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit bfa0c03
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6776c24c4a5816000883c71c
😎 Deploy Preview https://deploy-preview-1541--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

The action is deprecated and goes away when Kubebuilder GCP Project no longer be available.
Therefore, this PR replaces the action for the shell script that does the same check.
More info: https://github.com/kubernetes-sigs/kubebuilder-release-tools?tab=readme-ov-file#pr-verification-github-action-deprecated
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.22%. Comparing base (10f0f77) to head (bfa0c03).
Report is 97 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1541      +/-   ##
==========================================
- Coverage   74.25%   74.22%   -0.04%     
==========================================
  Files          42       42              
  Lines        3329     3329              
==========================================
- Hits         2472     2471       -1     
- Misses        676      677       +1     
  Partials      181      181              
Flag Coverage Δ
e2e 52.11% <ø> (ø)
unit 56.92% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@perdasilva perdasilva changed the title 🌱 Replace Depecated Action to validate the PR Title with script Replace Depecated Action to validate the PR Title with script Jan 22, 2025
@perdasilva perdasilva changed the title Replace Depecated Action to validate the PR Title with script 🌱 Replace Depecated Action to validate the PR Title with script Jan 22, 2025
@@ -0,0 +1,50 @@
#!/bin/bash
Copy link
Contributor

@perdasilva perdasilva Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering if something like:

if ! [[ $pr-title =~ ^[🌱⚠ ... ] ]]; then
  ...
fi

would be enough...

do we want to post success for [WIP] 🌱 ... ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are still failing when WIP is
The rules ,I think would still the same: kubernetes-sigs/[email protected]

@joe suggested we create an action there in the repo as well
I just had no effort to maintain the kubebuilder-release-tools
But let's put it in
/hold

I will see if I can change there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it real quick and it seems to let [WIP] titles through:

./hack/test/pr-title.sh "[WIP] 🌱 Replace Depecated Action to validate the PR Title with script"                                             
PR title is valid: 🌱 Replace Depecated Action to validate the PR Title with script

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we just fork the action repo and use that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean to start to maintain that inside of operator-framework?

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2025
@camilamacedo86
Copy link
Contributor Author

I will close for now.
I have been not have the required effort to see if I can fix it upstream :-(
Lets see first then we can circle back.

If needed, I reopen this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants