Skip to content

Conversation

anik120
Copy link
Contributor

@anik120 anik120 commented Jan 27, 2025

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@anik120 anik120 requested a review from a team as a code owner January 27, 2025 22:27
@anik120 anik120 marked this pull request as draft January 27, 2025 22:28
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 27, 2025
@netlify
Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 1ea802c
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67980aa260e6ae0008fa6fda
😎 Deploy Preview https://deploy-preview-1654--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@anik120 anik120 force-pushed the query-endpoint-with-sqlite branch from c8e62f3 to 1ea802c Compare January 27, 2025 22:37
@codecov
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 55.37849% with 112 lines in your changes missing coverage. Please review.

Project coverage is 66.88%. Comparing base (a46ff7d) to head (1ea802c).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
catalogd/internal/storage/sqlite.go 57.20% 87 Missing and 17 partials ⚠️
catalogd/cmd/catalogd/main.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1654      +/-   ##
==========================================
- Coverage   67.42%   66.88%   -0.54%     
==========================================
  Files          55       56       +1     
  Lines        4632     4877     +245     
==========================================
+ Hits         3123     3262     +139     
- Misses       1284     1373      +89     
- Partials      225      242      +17     
Flag Coverage Δ
e2e 53.21% <ø> (ø)
unit 54.56% <55.37%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anik120
Copy link
Contributor Author

anik120 commented Jan 29, 2025

Closing this in favor of #1643.

note: can be used as ref if there's conversation about a new implementation for storage.Instance

@anik120 anik120 closed this Jan 29, 2025
@anik120 anik120 changed the title Query endpoint with sqlite Metas endpoint with sqlite Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant