Skip to content

Conversation

camilamacedo86
Copy link
Contributor

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

camilamacedo86 and others added 12 commits January 29, 2025 17:49
…1.2.0-rc1 (operator-framework#1661)

* fix: the reference in the quick-star to get the latest release version properly

* fix: replace devel tag image with the version from release
…k#1663)

Extensive e2e tests revealed that operator-controller might run into
leader election timeouts during cluster bootstrap, causing sporadic
alerts being generated.

This commit uses recommended settings for leaderelection
LeaseDuration: 15s -> 137s
RenewDeadline: 10s -> 107s
RetryPeriod:    2s ->  26s

Warning: This will increase potential down-time of catalogd to 163s in
the worst case (up from 17s). (LeaseDuration + RetryPeriod)
…#1662)

Bumps [pymdown-extensions](https://github.com/facelessuser/pymdown-extensions) from 10.14.1 to 10.14.2.
- [Release notes](https://github.com/facelessuser/pymdown-extensions/releases)
- [Commits](facelessuser/pymdown-extensions@10.14.1...10.14.2)

---
updated-dependencies:
- dependency-name: pymdown-extensions
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ramework#1668)

The `verify-crd-compatibility` check needs to be executed from the root directory; otherwise, it fails to correctly resolve commit SHAs for comparison.

To address this, we have combined the checks for both CRDs into a single verification step, ensuring correctness while eliminating duplicate file references.
…#1672)

The SystemRoot store looks at the SSL_CERT_DIR and SSL_CERT_FILE
environment variables for certificate locations. Because these
variables are under control of the user, we should assume that
the user wants to control the contents of the SystemRoot, and
subsequently that those contents could change (as compared to certs
located in the default /etc/pki location).

Thus, we should watch those locations if they exist.

Signed-off-by: Todd Short <[email protected]>
…amework#1673)

Rename the flags that provide CAs to image pulling to indicate the use.
Keep the old flag around (for backward compatibility), but prefer the
new flag(s).

Signed-off-by: Todd Short <[email protected]>
…#1671)

Bumps [github.com/spf13/pflag](https://github.com/spf13/pflag) from 1.0.5 to 1.0.6.
- [Release notes](https://github.com/spf13/pflag/releases)
- [Commits](spf13/pflag@v1.0.5...v1.0.6)

---
updated-dependencies:
- dependency-name: github.com/spf13/pflag
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@camilamacedo86 camilamacedo86 requested a review from a team as a code owner January 31, 2025 13:17
@codecov
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 47.79412% with 71 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-v1.2@b4a25a7). Learn more about missing BASE report.

Files with missing lines Patch % Lines
internal/rukpak/source/util.go 50.87% 22 Missing and 6 partials ⚠️
catalogd/cmd/catalogd/main.go 0.00% 14 Missing ⚠️
catalogd/internal/source/containers_image.go 18.18% 3 Missing and 6 partials ⚠️
internal/util/fs.go 30.00% 5 Missing and 2 partials ⚠️
internal/rukpak/source/containers_image.go 40.00% 3 Missing and 3 partials ⚠️
cmd/operator-controller/main.go 80.00% 3 Missing and 1 partial ⚠️
internal/httputil/certpoolwatcher.go 78.57% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release-v1.2    #1679   +/-   ##
===============================================
  Coverage                ?   67.48%           
===============================================
  Files                   ?       57           
  Lines                   ?     4632           
  Branches                ?        0           
===============================================
  Hits                    ?     3126           
  Misses                  ?     1279           
  Partials                ?      227           
Flag Coverage Δ
e2e 53.31% <48.64%> (?)
unit 54.27% <33.82%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants