Skip to content

Conversation

camilamacedo86
Copy link
Contributor

  • Remove ginkgo from bingo in favor of go.mod version

  • fix(e2e): wait for leader election

TestClusterExtensionAfterOLMUpgrade was failing due to increased leader election timeouts, causing reconciliation checks to run before leadership was acquired.

This fix ensures the test explicitly waits for leader election logs ("successfully acquired lease") before verifying reconciliation.

  • Add leader election wait fit for catalogd upgrade-e2e

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

* Remove ginkgo from bingo in favor of go.mod version

Signed-off-by: Per Goncalves da Silva <[email protected]>

* fix(e2e): wait for leader election

TestClusterExtensionAfterOLMUpgrade was failing due to increased leader
election timeouts, causing reconciliation checks to run before leadership
was acquired.

This fix ensures the test explicitly waits for leader election logs
(`"successfully acquired lease"`) before verifying reconciliation.

* Add leader election wait fit for catalogd upgrade-e2e

Signed-off-by: Per Goncalves da Silva <[email protected]>

---------

Signed-off-by: Per Goncalves da Silva <[email protected]>
Co-authored-by: Per Goncalves da Silva <[email protected]>
Co-authored-by: Camila Macedo <[email protected]>
@camilamacedo86 camilamacedo86 requested a review from a team as a code owner January 31, 2025 17:00
@netlify
Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit b5de66a
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/679d01acfc053900087ff57b
😎 Deploy Preview https://deploy-preview-1685--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@camilamacedo86 camilamacedo86 changed the title 🐛 Unblock e2e (#1683) Update release v1.20 branch with main Jan 31, 2025
@camilamacedo86 camilamacedo86 changed the title Update release v1.20 branch with main 🌱 Update release v1.20 branch with main Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants