Skip to content

🌱 (cleanup): Remove 'make vet' from Makefile, simplify; keep 'vet' enabled in linting #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2025
Merged

🌱 (cleanup): Remove 'make vet' from Makefile, simplify; keep 'vet' enabled in linting #1718

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c105187
Remove 'make vet' from Makefile, simplify; keep 'vet' enabled in linting
camilamacedo86 Feb 5, 2025
07baba9
Apply suggestions from code review
camilamacedo86 Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .golangci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ linters:
- errorlint
- gci
- gofmt
- govet
- gosec
- importas
- misspell
Expand Down
10 changes: 3 additions & 7 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ generate: $(CONTROLLER_GEN) #EXHELP Generate code containing DeepCopy, DeepCopyI
$(CONTROLLER_GEN) object:headerFile="hack/boilerplate.go.txt" paths="./..."

.PHONY: verify
verify: tidy fmt vet generate manifests crd-ref-docs #HELP Verify all generated code is up-to-date.
verify: tidy fmt generate manifests crd-ref-docs #HELP Verify all generated code is up-to-date.
git diff --exit-code

.PHONY: fix-lint
Expand All @@ -128,10 +128,6 @@ fix-lint: $(GOLANGCI_LINT) #EXHELP Fix lint issues
fmt: #EXHELP Formats code
go fmt ./...

.PHONY: vet
vet: #EXHELP Run go vet against code.
go vet -tags '$(GO_BUILD_TAGS)' ./...

.PHONY: bingo-upgrade
bingo-upgrade: $(BINGO) #EXHELP Upgrade tools
@for pkg in $$($(BINGO) list | awk '{ print $$3 }' | tail -n +3 | sed 's/@.*//'); do \
Expand All @@ -151,7 +147,7 @@ verify-crd-compatibility: $(CRD_DIFF) manifests


.PHONY: test
test: manifests generate fmt vet test-unit test-e2e #HELP Run all tests.
test: manifests generate fmt test-unit test-e2e #HELP Run all tests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe put lint in its place?


.PHONY: e2e
e2e: #EXHELP Run the e2e tests.
Expand Down Expand Up @@ -291,7 +287,7 @@ $(BINARIES):
go build $(GO_BUILD_FLAGS) -tags '$(GO_BUILD_TAGS)' -ldflags '$(GO_BUILD_LDFLAGS)' -gcflags '$(GO_BUILD_GCFLAGS)' -asmflags '$(GO_BUILD_ASMFLAGS)' -o $(BUILDBIN)/$@ ./cmd/$@

.PHONY: build-deps
build-deps: manifests generate fmt vet
build-deps: manifests generate fmt

.PHONY: build go-build-local
build: build-deps go-build-local #HELP Build manager binary for current GOOS and GOARCH. Default target.
Expand Down