Skip to content

Conversation

@perdasilva
Copy link
Contributor

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

rashmi43 and others added 2 commits February 6, 2025 17:07
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 6, 2025
@netlify
Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 701d08b
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67a4bf1ba60614000817214b
😎 Deploy Preview https://deploy-preview-1721--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.80%. Comparing base (46cec30) to head (701d08b).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
internal/authentication/tokengetter.go 20.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1721      +/-   ##
==========================================
+ Coverage   67.47%   67.80%   +0.32%     
==========================================
  Files          59       59              
  Lines        5003     4985      -18     
==========================================
+ Hits         3376     3380       +4     
+ Misses       1380     1361      -19     
+ Partials      247      244       -3     
Flag Coverage Δ
e2e 52.96% <0.00%> (-0.42%) ⬇️
unit 55.00% <33.33%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2025
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@perdasilva perdasilva closed this Feb 11, 2025
@perdasilva perdasilva deleted the sa-error branch February 11, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants