Skip to content

Conversation

@LalatenduMohanty
Copy link
Member

This is a follow-up from the previous PR #421 i.e. commit d320249

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@LalatenduMohanty LalatenduMohanty requested a review from a team as a code owner February 6, 2025 15:58
@netlify
Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 4ac0ab7
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67bd1642a407640008b8f558
😎 Deploy Preview https://deploy-preview-1722--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LalatenduMohanty LalatenduMohanty changed the title 🌱 [WIP] Adding unit tests for catalog availability 🌱 [WIP] Adding more unit tests for catalog availability Feb 6, 2025
@LalatenduMohanty LalatenduMohanty force-pushed the catalogd_availability_tests branch 3 times, most recently from dc08ced to c5e5747 Compare February 19, 2025 21:44
@LalatenduMohanty LalatenduMohanty changed the title 🌱 [WIP] Adding more unit tests for catalog availability 🌱 Adding more unit tests for catalog availability Feb 20, 2025
@LalatenduMohanty LalatenduMohanty force-pushed the catalogd_availability_tests branch from c5e5747 to 0fc0411 Compare February 25, 2025 00:59
This is a follow-up from the previous PR operator-framework#421 i.e. commit d320249

Signed-off-by: Lalatendu Mohanty <[email protected]>
@LalatenduMohanty LalatenduMohanty force-pushed the catalogd_availability_tests branch from 0fc0411 to 4ac0ab7 Compare February 25, 2025 01:00
@LalatenduMohanty LalatenduMohanty changed the title 🌱 Adding more unit tests for catalog availability 🌱 Adding additional unit test for catalog availability Feb 25, 2025
@codecov
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.39%. Comparing base (4ecef20) to head (4ac0ab7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1722      +/-   ##
==========================================
+ Coverage   68.34%   68.39%   +0.05%     
==========================================
  Files          62       62              
  Lines        5117     5117              
==========================================
+ Hits         3497     3500       +3     
+ Misses       1390     1388       -2     
+ Partials      230      229       -1     
Flag Coverage Δ
e2e 51.78% <ø> (+0.15%) ⬆️
unit 55.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dtfranz dtfranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025
@dtfranz dtfranz added this pull request to the merge queue Feb 25, 2025
Merged via the queue into operator-framework:main with commit 38d2b46 Feb 25, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants