Skip to content

Conversation

@tmshort
Copy link
Contributor

@tmshort tmshort commented Feb 11, 2025

Fix #1706

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort tmshort requested a review from a team as a code owner February 11, 2025 19:12
@netlify
Copy link

netlify bot commented Feb 11, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 0c6d802
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67aba5917ff59500086f1a3f
😎 Deploy Preview https://deploy-preview-1745--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.34%. Comparing base (6dace7c) to head (0c6d802).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1745   +/-   ##
=======================================
  Coverage   67.34%   67.34%           
=======================================
  Files          61       61           
  Lines        5236     5236           
=======================================
  Hits         3526     3526           
  Misses       1449     1449           
  Partials      261      261           
Flag Coverage Δ
e2e 52.11% <ø> (-0.08%) ⬇️
unit 55.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2025
@LalatenduMohanty LalatenduMohanty added this pull request to the merge queue Feb 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 11, 2025
@LalatenduMohanty LalatenduMohanty added this pull request to the merge queue Feb 11, 2025
Merged via the queue into operator-framework:main with commit 16085ae Feb 11, 2025
23 checks passed
@tmshort tmshort deleted the combine-docs branch February 25, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move catalogd/docs to operator-controller/tree/main/docs

2 participants