Skip to content

Conversation

@camilamacedo86
Copy link
Contributor

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@camilamacedo86 camilamacedo86 requested a review from a team as a code owner February 20, 2025 13:59
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 20, 2025
@netlify
Copy link

netlify bot commented Feb 20, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit d2355a6
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67bc54f8321dd0000962d50e
😎 Deploy Preview https://deploy-preview-1796--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.34%. Comparing base (9b888eb) to head (d2355a6).
Report is 18 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1796   +/-   ##
=======================================
  Coverage   68.34%   68.34%           
=======================================
  Files          63       63           
  Lines        5117     5117           
=======================================
  Hits         3497     3497           
  Misses       1390     1390           
  Partials      230      230           
Flag Coverage Δ
e2e 51.62% <ø> (-0.08%) ⬇️
unit 55.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@camilamacedo86 camilamacedo86 force-pushed the doc-personas branch 2 times, most recently from 5431fbc to 0846d05 Compare February 24, 2025 11:08
- Add/remove workers
- Housekeeping CRDs

2. **Cluster Monitor** (Sub-role of Cluster Admin)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this basically SRE?

@grokspawn grokspawn mentioned this pull request Feb 28, 2025
2 tasks
@camilamacedo86
Copy link
Contributor Author

Closing this one in favor of #1824

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants