🌱 Update github.com/containers/image/v5 to v5.34.1 #1849
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| $(CONTROLLER_GEN) rbac:roleName=manager-role paths="./internal/catalogd/..." output:rbac:artifacts:config=$(KUSTOMIZE_CATD_RBAC_DIR) | ||
| $(CONTROLLER_GEN) webhook paths="./internal/catalogd/..." output:webhook:artifacts:config=$(KUSTOMIZE_CATD_WEBHOOKS_DIR) | ||
| GOFLAGS="-tags=$(GO_BUILD_TAGS)" $(CONTROLLER_GEN) rbac:roleName=manager-role paths="./internal/catalogd/..." output:rbac:artifacts:config=$(KUSTOMIZE_CATD_RBAC_DIR) | ||
| GOFLAGS="-tags=$(GO_BUILD_TAGS)" $(CONTROLLER_GEN) webhook paths="./internal/catalogd/..." output:webhook:artifacts:config=$(KUSTOMIZE_CATD_WEBHOOKS_DIR) |
There was a problem hiding this comment.
It will not work :-(
I am proposing we add its support here: kubernetes-sigs/controller-tools#1158 (comment)
But see has no env var or flag that allow us to pass the build tag so far: https://github.com/kubernetes-sigs/controller-tools/blob/main/pkg/loader/loader.go#L373-L379
The best away so far is replace the dep to downgrade it, see: #1846
There was a problem hiding this comment.
I think downgrade is dangerous, and the best way would be to move things around instead (short of fixing controller-tools)
openshift-merge-robot
added
the
needs-rebase
Add GOFLAGS to controller-gen invocations This is to deal with gpgme inclusion weirdness Signed-off-by: Todd Short <[email protected]>
openshift-merge-robot
added
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Done in #1892 |
4 participants
Add GOFLAGS to controller-gen invocations
This is to deal with gpgme inclusion weirdness
Description
Reviewer Checklist