Skip to content

Conversation

@bentito
Copy link
Contributor

@bentito bentito commented Mar 11, 2025

There are no Python resources currently in the project we see:

$ find . -type f -name "*.py"
$

The file command identified ./.tilt-support as Python, but this a known error, it is a Starlark file, which has similar syntax to Python.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

There are no Python resources currently in the project we see:
$ find . -type f -name "*.py"
$

The `file` command identified .tilt-support as Python, but this a known error, it is a Starlark file, which has similar syntax to Python

Signed-off-by: Brett Tofel <[email protected]>
@bentito bentito requested a review from a team as a code owner March 11, 2025 20:14
@netlify
Copy link

netlify bot commented Mar 11, 2025

Deploy Preview for olmv1 failed.

Name Link
🔨 Latest commit 8b59a18
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67d09aab96bbfe0008781d83

anik120
anik120 previously approved these changes Mar 11, 2025
Copy link
Contributor

@anik120 anik120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2025
@openshift-ci
Copy link

openshift-ci bot commented Mar 11, 2025

New changes are detected. LGTM label has been removed.

@bentito
Copy link
Contributor Author

bentito commented Mar 11, 2025

MkDocs needs this to generate GH pages.

@bentito bentito closed this Mar 11, 2025
@codecov
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.39%. Comparing base (995dc2b) to head (8b59a18).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1861      +/-   ##
==========================================
- Coverage   68.45%   68.39%   -0.06%     
==========================================
  Files          63       63              
  Lines        5136     5136              
==========================================
- Hits         3516     3513       -3     
- Misses       1390     1392       +2     
- Partials      230      231       +1     
Flag Coverage Δ
e2e 51.52% <ø> (-0.16%) ⬇️
unit 56.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants