✨ Implement Boxcutter #1946
Merged
✨ Implement Boxcutter #1946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-merge-robot
added
the
needs-rebase
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
joelanford
reviewed
Apr 30, 2025
joelanford
reviewed
Apr 30, 2025
joelanford
reviewed
Apr 30, 2025
Comment on lines
195
to
360
| hasher.Reset() | ||
|
|
||
| printer := spew.ConfigState{ | ||
| Indent: " ", | ||
| SortKeys: true, | ||
| DisableMethods: true, | ||
| SpewKeys: true, | ||
| } | ||
| if _, err := printer.Fprintf(hasher, "%#v", objectToWrite); err != nil { | ||
| panic(err) | ||
| } |
There was a problem hiding this comment.
Is this an OLM-ism or a boxcutter-ism? I wonder if json.NewEncoder(hasher).Encode(objectToWrite) would be better?
There was a problem hiding this comment.
This is a kubernetes apimachinery thing:
https://github.com/kubernetes/kubernetes/blob/627ce4946ccd6b67bc18f5a4dda92cf6c583e9b7/pkg/util/hash/hash.go#L26-L32
https://github.com/kubernetes/apimachinery/blob/master/pkg/util/dump/dump.go
I'll import from apimachinery next.
joelanford
reviewed
Apr 30, 2025
4 tasks
thetechnick
force-pushed
the
poc-boxcutter
branch
from
36d9cd7 to
b401796
Compare
openshift-merge-robot
removed
the
needs-rebase
perdasilva
force-pushed
the
poc-boxcutter
branch
2 times, most recently
from
1c23866 to
dc66501
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1946 +/- ##
==========================================
- Coverage 72.79% 72.03% -0.76%
==========================================
Files 79 85 +6
Lines 7421 8332 +911
==========================================
+ Hits 5402 6002 +600
- Misses 1670 1927 +257
- Partials 349 403 +54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
perdasilva
force-pushed
the
poc-boxcutter
branch
6 times, most recently
from
35cdf3b to
370bac6
Compare
tmshort
reviewed
Jul 21, 2025
perdasilva
force-pushed
the
poc-boxcutter
branch
9 times, most recently
from
4f39c38 to
842037e
Compare
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Joe Lanford <[email protected]>
Signed-off-by: Joe Lanford <[email protected]>
…re component Signed-off-by: Joe Lanford <[email protected]>
Signed-off-by: Todd Short <[email protected]>
Signed-off-by: Todd Short <[email protected]>
Ensure informers are started before reconciling and stopped before removing the finalizer.
…on annotations Signed-off-by: Joe Lanford <[email protected]>
This change accommodates the possibility of a revision that is currently rolling out, which is possible for appliers that perform rollouts asynchronously. Signed-off-by: Joe Lanford <[email protected]>
Signed-off-by: Joe Lanford <[email protected]>
Signed-off-by: Joe Lanford <[email protected]>
Signed-off-by: Joe Lanford <[email protected]>
…conciliation Signed-off-by: Joe Lanford <[email protected]>
Signed-off-by: Joe Lanford <[email protected]>
Signed-off-by: Joe Lanford <[email protected]>
Defines a set of phases which facilitate a smoother installation vs applying every resource in the bundle all at once. Signed-off-by: Daniel Franz <[email protected]>
Captures conditions and reasons used by ClusterExtensionRevision into consts. Signed-off-by: Daniel Franz <[email protected]>
thetechnick
force-pushed
the
poc-boxcutter
branch
from
a0adcc0 to
c175077
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reviewer Checklist