-
Notifications
You must be signed in to change notification settings - Fork 68
✨ (hack) Make service-account optional #1956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d57ed80 to
0453eab
Compare
Signed-off-by: Per Goncalves da Silva <[email protected]>
| //+kubebuilder:rbac:groups=core,resources=serviceaccounts/token,verbs=create | ||
| //+kubebuilder:rbac:groups=apiextensions.k8s.io,resources=customresourcedefinitions,verbs=get | ||
| //+kubebuilder:rbac:groups=rbac.authorization.k8s.io,resources=clusterroles;clusterrolebindings;roles;rolebindings,verbs=list;watch | ||
| //+kubebuilder:rbac:groups=*,resources=*,verbs=* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would not it result in OLM have all possible permissions, do we want that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's an open question at the moment. But given that we can create tokens for any service account, that's essentially what we have already XDD
| cExt := o.(*ocv1.ClusterExtension) | ||
| if cExt.Spec.ServiceAccount == nil { | ||
| return rest.CopyConfig(c), nil | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, can we create one to bind if the user does not provide an SA?
Is that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the point of this PR was just to demo the kind of UX I'm after. It just made it so that you could stamp out a ClusterExtension and everything would "just work". I didn't really think about all the odds and ends. I think the idea here was: if user doesn't specify an sa, just use olm's.
Description
Demo
Reviewer Checklist