Skip to content

Conversation

@grokspawn
Copy link
Contributor

Description

From current K8S_VERSION calculation in Makefile, this tool will receive the version and the location of the modfile for kind, retrieve the image.go file from the floating tag's release of the image.go module which contains the floating k8s version tag used for the node image, compare that floating tag to ensure that the default kind-node-image tag is greater or equal to the currently selected k8s version.

Tested to verify this exits status 1 before the kind version bump to v0.29.0 (included here just because it will permafail without it in current conditions.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jun 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign camilamacedo86 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Jun 25, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 9f8ef6d
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/685c68637968b30008d9d59e
😎 Deploy Preview https://deploy-preview-2048--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 79 lines in your changes missing coverage. Please review.

Project coverage is 73.02%. Comparing base (00b965c) to head (9f8ef6d).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
hack/tools/k8saligner/main.go 0.00% 79 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2048      +/-   ##
==========================================
- Coverage   73.82%   73.02%   -0.80%     
==========================================
  Files          81       82       +1     
  Lines        7365     7444      +79     
==========================================
- Hits         5437     5436       -1     
- Misses       1588     1668      +80     
  Partials      340      340              
Flag Coverage Δ
e2e 44.06% <ø> (ø)
unit 59.60% <0.00%> (-0.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@grokspawn grokspawn closed this Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant