Skip to content

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Jun 26, 2025

  • Move feature overlays to be components.
  • Create experimental and e2e overlays and manifests.
  • Use e2e manifests for testing.
  • Create test-experimental-e2e target.
  • Remove unused webhook manifests.
  • Add run of experimental-e2e

This is a first step, mostly moving things around, and there's a lot of duplication in the overlays.

This also fixes the issue with the current test-e2e modifying the standard manifest with e2e parameters, leaving a dirty workspace. This changes the manifest used buy the e2e test to be it's own standard-e2e manifest.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort tmshort requested a review from a team as a code owner June 26, 2025 15:20
Copy link

netlify bot commented Jun 26, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 763304a
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/685d6c10036c310008cdef61
😎 Deploy Preview https://deploy-preview-2053--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci openshift-ci bot requested a review from bentito June 26, 2025 15:20
Copy link

openshift-ci bot commented Jun 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelanford for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested a review from gavinmbell June 26, 2025 15:20
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.80%. Comparing base (fca620f) to head (763304a).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2053   +/-   ##
=======================================
  Coverage   73.80%   73.80%           
=======================================
  Files          81       81           
  Lines        7365     7365           
=======================================
  Hits         5436     5436           
  Misses       1589     1589           
  Partials      340      340           
Flag Coverage Δ
e2e 44.06% <ø> (-0.09%) ⬇️
unit 60.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

* Move feature overlays to be components.
* Create experimental and e2e overlays and manifests.
* Use e2e manifests for testing.
* Create `test-experimental-e2e` target.
* Remove unused webhook manifests.
* Add run of experimental-e2e

This is a first step, mostly moving things around, and there's a lot
of duplication in the overlays.

This also fixes the issue with the current test-e2e modifying the
standard manifest with e2e parameters, leaving a dirty workspace. This
changes the manifest used buy the e2e test to be it's own standard-e2e
manifest.

Signed-off-by: Todd Short <[email protected]>
@tmshort
Copy link
Contributor Author

tmshort commented Jun 26, 2025

Closing in favor of a number of smaller PRs.

@tmshort tmshort closed this Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant