Skip to content

Conversation

@camilamacedo86
Copy link
Contributor

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@camilamacedo86 camilamacedo86 requested a review from a team as a code owner July 16, 2025 02:14
@netlify
Copy link

netlify bot commented Jul 16, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 5607b78
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/68770b0907dad10008ae5063
😎 Deploy Preview https://deploy-preview-2104--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci openshift-ci bot requested review from bentito and grokspawn July 16, 2025 02:14
@codecov
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.48%. Comparing base (36809b3) to head (5607b78).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2104   +/-   ##
=======================================
  Coverage   73.48%   73.48%           
=======================================
  Files          78       78           
  Lines        7240     7240           
=======================================
  Hits         5320     5320           
  Misses       1568     1568           
  Partials      352      352           
Flag Coverage Δ
e2e 43.80% <ø> (-0.10%) ⬇️
experimental-e2e 50.09% <ø> (+0.18%) ⬆️
unit 58.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@camilamacedo86 camilamacedo86 changed the title (NOT MERGE) - Test 🌱 Remove unused method from the tests Jul 16, 2025
@tmshort
Copy link
Contributor

tmshort commented Jul 16, 2025

go-apidiff is acceptable.
/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jul 16, 2025
@tmshort tmshort merged commit 6e5c186 into operator-framework:main Jul 16, 2025
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants