Skip to content

Conversation

joelanford
Copy link
Member

Description

The intention of the tilt-local-dev patches is to delete the --leader-elect flags in catalogd and operator-controller. In the kustomize reshuffling, it looks like flags moved around, but the tilt patch was not updated to use the correct index for deletion.

This fixes that.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@joelanford joelanford requested a review from a team as a code owner July 30, 2025 19:15
@netlify
Copy link

netlify bot commented Jul 30, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit b590b70
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/688a6f5c6706d20008d7f608
😎 Deploy Preview https://deploy-preview-2127--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci openshift-ci bot requested review from OchiengEd and tmshort July 30, 2025 19:15
@joelanford joelanford changed the title tilt: delete at correct index to remove --leader-elect flag for catalogd 🌱 tilt: delete at correct index to remove --leader-elect flag for catalogd Jul 30, 2025
@codecov
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.59%. Comparing base (a023cf7) to head (b590b70).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2127   +/-   ##
=======================================
  Coverage   73.59%   73.59%           
=======================================
  Files          78       78           
  Lines        7260     7260           
=======================================
  Hits         5343     5343           
  Misses       1567     1567           
  Partials      350      350           
Flag Coverage Δ
e2e 43.50% <ø> (ø)
experimental-e2e 56.17% <ø> (ø)
unit 58.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@grokspawn
Copy link
Contributor

/approve
/lgtm

🤷

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2025
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jul 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2025
@joelanford joelanford merged commit e9c5b6e into operator-framework:main Jul 30, 2025
22 of 23 checks passed
@joelanford joelanford deleted the catalogd-tilt-fix branch July 30, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants