Skip to content

Conversation

perdasilva
Copy link
Contributor

Description

Box the boxcutter, configuration, and helm efforts will require an architecture that allows for multiple bundle formats. This PR starts us on that path by creating the simplest Bundle interface:

type Bundle interface {
  FS() fs.FS
}

and updating the Applier to use it. We will want to also update the Resolver and the ImagePuller to use the Bundle interface / API.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Per Goncalves da Silva <[email protected]>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 25, 2025
@netlify
Copy link

netlify bot commented Aug 25, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit e1f1911
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/68ac7a63ae0f5f0008402d1f
😎 Deploy Preview https://deploy-preview-2160--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci
Copy link

openshift-ci bot commented Aug 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thetechnick for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Aug 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.77%. Comparing base (dff07d5) to head (e1f1911).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2160      +/-   ##
==========================================
- Coverage   72.79%   72.77%   -0.03%     
==========================================
  Files          79       80       +1     
  Lines        7340     7345       +5     
==========================================
+ Hits         5343     5345       +2     
- Misses       1651     1653       +2     
- Partials      346      347       +1     
Flag Coverage Δ
e2e 44.39% <64.28%> (-0.04%) ⬇️
experimental-e2e 54.92% <64.28%> (-0.05%) ⬇️
unit 58.21% <71.42%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@perdasilva perdasilva marked this pull request as ready for review August 26, 2025 12:11
@perdasilva perdasilva requested a review from a team as a code owner August 26, 2025 12:11
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2025
@openshift-ci openshift-ci bot requested review from anik120 and joelanford August 26, 2025 12:11
@perdasilva perdasilva closed this Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant