-
Notifications
You must be signed in to change notification settings - Fork 67
✨ ClusterExtensionConfig API #2163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ ClusterExtensionConfig API #2163
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2163 +/- ##
==========================================
+ Coverage 72.67% 72.71% +0.04%
==========================================
Files 79 79
Lines 7340 7378 +38
==========================================
+ Hits 5334 5365 +31
- Misses 1659 1666 +7
Partials 347 347
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
544b420 to
5dd6ee0
Compare
5dd6ee0 to
ae000a6
Compare
313ea23 to
1c8e5c9
Compare
5c921e0 to
a78b3a5
Compare
a78b3a5 to
8b1ebf2
Compare
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
8b1ebf2 to
1d1de7c
Compare
|
/approve |
| // | ||
| // config is optional. When not specified, the default configuration of the resolved bundle will be used. | ||
| // | ||
| // <opcon:experimental> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look at that experimental tag...
|
/lgtm |
1d1de7c to
cb74b27
Compare
|
/lgtm |
|
/hold |
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
cb74b27 to
6ebde89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120, joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
With operator-framework#2166 and operator-framework#2163 in place, annotation based config support can be removed. Signed-off-by: Anik Bhattacharjee <[email protected]>
With operator-framework#2166 and operator-framework#2163 in place, annotation based config support can be removed. Signed-off-by: Anik Bhattacharjee <[email protected]>
With operator-framework#2166 and operator-framework#2163 in place, annotation based config support can be removed. Signed-off-by: Anik Bhattacharjee <[email protected]>
* OPRUN-4106: remove support for annotation based config With #2166 and #2163 in place, annotation based config support can be removed. Signed-off-by: Anik Bhattacharjee <[email protected]> * update docs and demo to use new config spec --------- Signed-off-by: Anik Bhattacharjee <[email protected]>
Description
.spec.configstanza to the experimental ClusterExtension API as a discriminated union with a single type: "Inline"Example
Reviewer Checklist