Skip to content

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented Aug 29, 2025

Description

Adds a config module to unmarshall and validate registry+v1 bundle configuration passed in through the ClusterExtension.

Validation is made via the generation of a json schema for the bundle.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 29, 2025
@perdasilva perdasilva changed the title ✨ Add config support with jsonschema validation ✨ Add config support with jsonschema validation [WIP] Aug 29, 2025
Copy link

netlify bot commented Aug 29, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit e2cd039
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/68c28ed7eef2fc000829f576
😎 Deploy Preview https://deploy-preview-2177--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Aug 29, 2025

Codecov Report

❌ Patch coverage is 82.63473% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.27%. Comparing base (1821160) to head (e2cd039).
⚠️ Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
...rator-controller/rukpak/bundle/bundlecfg/config.go 81.04% 19 Missing and 10 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2177      +/-   ##
==========================================
+ Coverage   72.09%   72.27%   +0.17%     
==========================================
  Files          85       86       +1     
  Lines        8401     8559     +158     
==========================================
+ Hits         6057     6186     +129     
- Misses       1941     1960      +19     
- Partials      403      413      +10     
Flag Coverage Δ
e2e 38.52% <5.98%> (-0.87%) ⬇️
experimental-e2e 45.17% <0.00%> (-0.98%) ⬇️
unit 57.30% <82.63%> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@perdasilva perdasilva force-pushed the config-support-converter branch 4 times, most recently from 1d44a8f to 86f8c3a Compare September 3, 2025 14:26
@perdasilva perdasilva changed the title ✨ Add config support with jsonschema validation [WIP] ✨ OPRUN-4112: Add config support with jsonschema validation [WIP] Sep 3, 2025
@perdasilva perdasilva force-pushed the config-support-converter branch from 86f8c3a to 3a81ef9 Compare September 3, 2025 14:50
Copy link

openshift-ci bot commented Sep 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tmshort for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@perdasilva perdasilva force-pushed the config-support-converter branch from 3a81ef9 to 16bb72e Compare September 3, 2025 15:53
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2025
@perdasilva perdasilva force-pushed the config-support-converter branch from 16bb72e to 796cd9d Compare September 8, 2025 09:33
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2025
@perdasilva perdasilva force-pushed the config-support-converter branch 2 times, most recently from ea083d5 to 0390171 Compare September 8, 2025 13:47
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2025
@perdasilva perdasilva force-pushed the config-support-converter branch from 0390171 to 31d7388 Compare September 8, 2025 13:48
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2025
@perdasilva perdasilva force-pushed the config-support-converter branch 2 times, most recently from 97597c7 to 6093559 Compare September 9, 2025 14:59
@perdasilva perdasilva marked this pull request as ready for review September 9, 2025 15:01
@perdasilva perdasilva requested a review from a team as a code owner September 9, 2025 15:01
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2025
@perdasilva perdasilva changed the title ✨ OPRUN-4112: Add config support with jsonschema validation [WIP] ✨ OPRUN-4112: Add config support with jsonschema validation Sep 9, 2025
@perdasilva perdasilva marked this pull request as draft September 9, 2025 15:39
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2025
Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva force-pushed the config-support-converter branch 2 times, most recently from 8f66a44 to 404f335 Compare September 11, 2025 07:57
@perdasilva perdasilva force-pushed the config-support-converter branch from 404f335 to e2cd039 Compare September 11, 2025 08:56
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 13, 2025
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@perdasilva
Copy link
Contributor Author

closing as stale

@perdasilva perdasilva closed this Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants