🐛 (fix): unhandle changes for crd upgrade safety ( OCPBUGS-59518 )

[camilamacedo86]

• Keep unhandled spec changes as errors; message: "unhandled changes found"

Reviewer Checklist

• [N/A ] API Go Documentation
• Tests: Unit Tests (and E2E Tests, if appropriate)
• Comprehensive Commit Messages
• [N/A] Links to related GitHub Issue(s)

[netlify]

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	3932b0e
🔍 Latest deploy log	https://app.netlify.com/projects/olmv1/deploys/68b8415c49b4db0008fbcbf2
😎 Deploy Preview	https://deploy-preview-2179--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thetechnick for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• internal/operator-controller/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[camilamacedo86]

Hi @joelanford @perdasilva

It seems to be the real fix for OCPBUGS-59518.
I hope that helps out.

Moreover, IMHO we should perform additional checks and carefully evaluate the errors in those unhandled scenarios. It might be worth verifying if a newer version of the library addresses this, or if there are other improvements we could apply. In short, we should confirm whether there’s truly nothing else we can do here to make the handling more robust.

[codecov]

Codecov Report

❌ Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.84%. Comparing base (1e678d5) to head (3932b0e).

Files with missing lines	Patch %	Lines
...ak/preflights/crdupgradesafety/crdupgradesafety.go	76.92%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2179      +/-   ##
==========================================
+ Coverage   72.76%   72.84%   +0.07%     
==========================================
  Files          79       79              
  Lines        7391     7397       +6     
==========================================
+ Hits         5378     5388      +10     
+ Misses       1666     1662       -4     
  Partials      347      347              

Flag	Coverage Δ
e2e	44.18% <0.00%> (-0.09%)	⬇️
experimental-e2e	56.17% <0.00%> (-0.01%)	⬇️
unit	58.36% <76.92%> (+0.08%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.