Skip to content

Conversation

anik120
Copy link
Contributor

@anik120 anik120 commented Sep 15, 2025

Ref: https://blog.podman.io/2025/08/upcoming-migration-of-three-containers-repositories-to-monorepo/

Also update operator-registry to v1.59.0 which also contains the same migration,
so that there are no indirect dependency to any old containers repo.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@anik120 anik120 requested a review from a team as a code owner September 15, 2025 19:21
Comment on lines +224 to +225
go.podman.io/common v0.65.0 // indirect
go.podman.io/storage v1.60.0 // indirect
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tada!

Copy link

netlify bot commented Sep 15, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 98bafa9
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/68c86bbec9a0350008aa2a50
😎 Deploy Preview https://deploy-preview-2221--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@anik120 anik120 force-pushed the redo-containers-lib-migration branch from 660a5d3 to 03c0fcb Compare September 15, 2025 19:23
@anik120 anik120 changed the title ✨Revert "Revert "migrate containers libs to new mono repo" #2215" ✨Revert "Revert "migrate containers libs to new mono repo"" Sep 15, 2025
@tmshort
Copy link
Contributor

tmshort commented Sep 15, 2025

Can you change the commit headline (and the PR title) to remove "revert", so it's just:

migrate containers libs to new mono repo

I'd rather not do revert...revert... etc.

Copy link

codecov bot commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.17%. Comparing base (948f32d) to head (98bafa9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2221      +/-   ##
==========================================
+ Coverage   72.05%   72.17%   +0.11%     
==========================================
  Files          85       85              
  Lines        8407     8407              
==========================================
+ Hits         6058     6068      +10     
+ Misses       1948     1939       -9     
+ Partials      401      400       -1     
Flag Coverage Δ
e2e 39.16% <ø> (-0.04%) ⬇️
experimental-e2e 46.15% <ø> (+0.09%) ⬆️
unit 57.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Ref: https://blog.podman.io/2025/08/upcoming-migration-of-three-containers-repositories-to-monorepo/

Also update operator-registry to v1.59.0 which also contains the same migration,
so that there are no indirect dependency to any old containers repo.
@anik120 anik120 force-pushed the redo-containers-lib-migration branch from 03c0fcb to 98bafa9 Compare September 15, 2025 19:40
@anik120 anik120 changed the title ✨Revert "Revert "migrate containers libs to new mono repo"" ✨migrate containers libs to new mono repo Sep 15, 2025
@anik120
Copy link
Contributor Author

anik120 commented Sep 15, 2025

Can you change the commit headline (and the PR title) to remove "revert", so it's just:

migrate containers libs to new mono repo

I'd rather not do revert...revert... etc.

Done ✅

@tmshort
Copy link
Contributor

tmshort commented Sep 15, 2025

/approve

Copy link

openshift-ci bot commented Sep 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2025
@anik120 anik120 changed the title ✨migrate containers libs to new mono repo ✨OPRUN-4120: migrate containers libs to new mono repo Sep 15, 2025
@tmshort
Copy link
Contributor

tmshort commented Sep 15, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 27b05e7 into operator-framework:main Sep 15, 2025
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants