-
Notifications
You must be signed in to change notification settings - Fork 67
🌱 Refactor NewBundleFS test utility to builder pattern #2237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Refactor NewBundleFS test utility to builder pattern #2237
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2237 +/- ##
==========================================
+ Coverage 71.87% 72.61% +0.73%
==========================================
Files 86 86
Lines 8474 8592 +118
==========================================
+ Hits 6091 6239 +148
+ Misses 1982 1943 -39
- Partials 401 410 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ffc7bfa
to
f187d48
Compare
Signed-off-by: Per Goncalves da Silva <[email protected]>
f187d48
to
1ccac24
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pedjak, thetechnick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5f37a67
into
operator-framework:main
Description
While doing some refactoring work to fix a bug, it became clear I'd need better test tooling to create test bundle filesystems. This PR updates the NewBundleFS utility using the builder pattern to help compose a valid registry+v1 bundle FS for testing
Reviewer Checklist