Skip to content

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented Sep 26, 2025

Description

While doing some refactoring work to fix a bug, it became clear I'd need better test tooling to create test bundle filesystems. This PR updates the NewBundleFS utility using the builder pattern to help compose a valid registry+v1 bundle FS for testing

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@perdasilva perdasilva requested a review from a team as a code owner September 26, 2025 15:52
Copy link

netlify bot commented Sep 26, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 1ccac24
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/68dd4fb9c0f1a30008dc8d6b
😎 Deploy Preview https://deploy-preview-2237--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Sep 26, 2025

Codecov Report

❌ Patch coverage is 90.62500% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.61%. Comparing base (55d9dfb) to head (1ccac24).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...ontroller/rukpak/util/testing/bundlefs/bundlefs.go 90.47% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2237      +/-   ##
==========================================
+ Coverage   71.87%   72.61%   +0.73%     
==========================================
  Files          86       86              
  Lines        8474     8592     +118     
==========================================
+ Hits         6091     6239     +148     
+ Misses       1982     1943      -39     
- Partials      401      410       +9     
Flag Coverage Δ
e2e 38.58% <0.00%> (-0.53%) ⬇️
experimental-e2e 45.73% <0.00%> (-0.49%) ⬇️
unit 57.77% <90.62%> (+0.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@perdasilva perdasilva force-pushed the refactor-new-bundle-fs branch 3 times, most recently from ffc7bfa to f187d48 Compare October 1, 2025 15:46
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2025
@perdasilva perdasilva force-pushed the refactor-new-bundle-fs branch from f187d48 to 1ccac24 Compare October 1, 2025 15:58
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2025
@pedjak
Copy link
Contributor

pedjak commented Oct 1, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2025
@perdasilva perdasilva changed the title 🌱 Update NewBundleFS test utility 🌱 Refactor NewBundleFS test utility to builder pattern Oct 2, 2025
Copy link

openshift-ci bot commented Oct 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pedjak, thetechnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 5f37a67 into operator-framework:main Oct 2, 2025
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants