Skip to content

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented Sep 26, 2025

Description

The RegistryV1HelmChartProvider was letting through bundles that don't support AllNamespaces mode.

RegistryV1HelmChartProvider is updated to handle the SingleOwnNamespace feature in the same way the Webhook feature is handled. In a follow-up PR, GetWatchNamespace() (which checks for the SingleOwnNamespace feature) will be moved into this component.

Note: This PR used to have an e2e tests to ensure bundles not supported by the standard OLMv1 profile get rejected. But, there's currently no way to execute an e2e test on the standard profile only. So, I've removed it and will add in a follow up PR once we've addressed this the right way.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@perdasilva perdasilva requested a review from a team as a code owner September 26, 2025 17:30
Copy link

netlify bot commented Sep 26, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 076a509
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/68dd437e3db9790008394d15
😎 Deploy Preview https://deploy-preview-2238--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tmshort
Copy link
Contributor

tmshort commented Sep 26, 2025

The experimental-e2e is not passing...
But I'll run them again (one was a timeout condition)

@perdasilva perdasilva changed the title 🐛 Fix install mode support gating 🐛 OCPBUGS-62021: Fix install mode support gating Sep 29, 2025
@perdasilva
Copy link
Contributor Author

The experimental-e2e is not passing... But I'll run them again (one was a timeout condition)

Yeah - these aren't really meant to be run in experimental mode. It's to check that the things that are enabled in experimental mode aren't enabled out of experimental mode

Signed-off-by: Per Goncalves da Silva <[email protected]>
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.15%. Comparing base (55d9dfb) to head (076a509).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
internal/operator-controller/applier/provider.go 76.92% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2238      +/-   ##
==========================================
+ Coverage   71.87%   72.15%   +0.27%     
==========================================
  Files          86       86              
  Lines        8474     8590     +116     
==========================================
+ Hits         6091     6198     +107     
- Misses       1982     1984       +2     
- Partials      401      408       +7     
Flag Coverage Δ
e2e 38.68% <63.33%> (-0.43%) ⬇️
experimental-e2e 45.61% <0.00%> (-0.60%) ⬇️
unit 57.27% <66.66%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2025
Copy link

openshift-ci bot commented Oct 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, pedjak, thetechnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit fbd2e65 into operator-framework:main Oct 2, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants