-
Notifications
You must be signed in to change notification settings - Fork 67
🐛 OCPBUGS-62021: Fix install mode support gating #2238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 OCPBUGS-62021: Fix install mode support gating #2238
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The experimental-e2e is not passing... |
Yeah - these aren't really meant to be run in experimental mode. It's to check that the things that are enabled in experimental mode aren't enabled out of experimental mode |
95286aa
to
b46119b
Compare
Signed-off-by: Per Goncalves da Silva <[email protected]>
b46119b
to
076a509
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2238 +/- ##
==========================================
+ Coverage 71.87% 72.15% +0.27%
==========================================
Files 86 86
Lines 8474 8590 +116
==========================================
+ Hits 6091 6198 +107
- Misses 1982 1984 +2
- Partials 401 408 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn, pedjak, thetechnick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fbd2e65
into
operator-framework:main
Description
The RegistryV1HelmChartProvider was letting through bundles that don't support AllNamespaces mode.
RegistryV1HelmChartProvider is updated to handle the SingleOwnNamespace feature in the same way the Webhook feature is handled. In a follow-up PR, GetWatchNamespace() (which checks for the SingleOwnNamespace feature) will be moved into this component.
Note: This PR used to have an e2e tests to ensure bundles not supported by the standard OLMv1 profile get rejected. But, there's currently no way to execute an e2e test on the standard profile only. So, I've removed it and will add in a follow up PR once we've addressed this the right way.
Reviewer Checklist