Skip to content

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Sep 29, 2025

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort tmshort requested a review from a team as a code owner September 29, 2025 13:16
@openshift-ci openshift-ci bot requested review from dtfranz and trgeiger September 29, 2025 13:16
Copy link

netlify bot commented Sep 29, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit f5269f3
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/68da8b6424beee00086e430f
😎 Deploy Preview https://deploy-preview-2239--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

openshift-ci bot commented Sep 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kevinrizza for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@pedjak pedjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about that we call this variable a bit more generic, given that we could pass not only -skip arg? Like EXTRA_GO_TEST_ARGS?

Copy link

codecov bot commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.95%. Comparing base (55d9dfb) to head (f5269f3).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2239      +/-   ##
==========================================
+ Coverage   71.87%   71.95%   +0.07%     
==========================================
  Files          86       86              
  Lines        8474     8575     +101     
==========================================
+ Hits         6091     6170      +79     
- Misses       1982     1995      +13     
- Partials      401      410       +9     
Flag Coverage Δ
e2e 38.60% <ø> (-0.51%) ⬇️
experimental-e2e 45.57% <ø> (-0.64%) ⬇️
unit 57.21% <ø> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@pedjak pedjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good, just update the commit and PR title to reflect the semantic of the new variable.

@tmshort tmshort closed this Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants