✨ Deprecate spec.ServiceAccount and remove synthetic permissions feature #2242
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,8 +49,7 @@ const ( | |
| // ClusterExtensionSpec defines the desired state of ClusterExtension | ||
| type ClusterExtensionSpec struct { | ||
| // namespace is a reference to a Kubernetes namespace. | ||
| // It designates the default namespace where namespace-scoped resources | ||
| // for the extension are applied to the cluster. | ||
| // Some extensions may contain namespace-scoped resources to be applied in other namespaces. | ||
| // This namespace must exist. | ||
|
|
@@ -67,14 +66,13 @@ type ClusterExtensionSpec struct { | |
| // +kubebuilder:validation:Required | ||
| Namespace string `json:"namespace"` | ||
|
|
||
| // Deprecated: ServiceAccount is ignored by OLM and will be removed in a future release. | ||
| // serviceAccount was a reference to the ServiceAccount used to perform all interactions | ||
| // with the cluster that are required to manage the extension. | ||
| // serviceAccount is optional. | ||
| // | ||
| // +kubebuilder:validation:Optional | ||
| ServiceAccount ServiceAccountReference `json:"serviceAccount,omitzero"` | ||
|
There was a problem hiding this comment. I'm not sure what the kubebuilder magic is which would generate the 'deprecated' label for this field, but it would be great to do it, like https://kubernetes.io/blog/2020/09/03/warnings/#custom-resource-definitions. There was a problem hiding this comment. |
||
|
|
||
| // source is a required field which selects the installation source of content | ||
| // for this ClusterExtension. Selection is performed by setting the sourceType. | ||
|
|
@@ -369,8 +367,9 @@ type CatalogFilter struct { | |
| UpgradeConstraintPolicy UpgradeConstraintPolicy `json:"upgradeConstraintPolicy,omitempty"` | ||
| } | ||
|
|
||
| // Deprecated: ServiceAccount is ignored by OLM and will be removed in a future release. | ||
| type ServiceAccountReference struct { | ||
| // Deprecated: ServiceAccount.Name is ignored by OLM and will be removed in a future release. | ||
| // name is a required, immutable reference to the name of the ServiceAccount | ||
| // to be used for installation and management of the content for the package | ||
| // specified in the packageName field. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to also log a warning during reconciliation if this field is still set by a user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some concerns about generating a log on each reconcile. It looks like k8s uses a metric to express "thing is using a deprecated API" and that feels like an approach which could scale better.