✨ OPRUN-4206: Support disabling feature-gates #2271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tmshort
changed the title
tmshort
changed the title
The Helm manifests only support _enabling_ feature-gates. To allow for flexibility in configuring mutually-exclusive feature-gates and additional parameters that might be needed, add Helm templating for disabled feature gates and extra arguments to the deployments. NOTE: This deprecates the old location of feature-gate config, and moves it to a new location. This is necessary to keep downstream from breaking during this transition. Signed-off-by: Todd Short <[email protected]>
tmshort
force-pushed
the
disable-flags
branch
from
111a8c2 to
fff4028
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2271 +/- ##
==========================================
- Coverage 73.08% 73.00% -0.09%
==========================================
Files 88 88
Lines 8743 8743
==========================================
- Hits 6390 6383 -7
- Misses 1940 1947 +7
Partials 413 413
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 292c0db
into
operator-framework:main
24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Helm manifests only support enabling feature-gates. To allow for flexibility in configuring mutually-exclusive feature-gates and additional parameters that might be needed, add Helm templating for disabled feature gates and extra arguments to the deployments.
NOTE: This deprecates the old location of feature-gate config, and moves it to a new location. This is necessary to keep downstream from breaking during this transition.
Description
Reviewer Checklist