Skip to content

Conversation

perdasilva
Copy link
Contributor

Description

This PR adds a CLAUDE.md file to assist maintainers / developers using claude code in their workflow.

This file was generated by claude code.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva requested a review from a team as a code owner October 17, 2025 07:49
@openshift-ci openshift-ci bot requested review from pedjak and tmshort October 17, 2025 07:49
Copy link

openshift-ci bot commented Oct 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tmshort for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

netlify bot commented Oct 17, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 731e511
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/68f1f50136b9c90008e1ac50
😎 Deploy Preview https://deploy-preview-2275--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pedjak
Copy link
Contributor

pedjak commented Oct 17, 2025

@joelanford has opened a similar PR: #2274 which one should go in?

@perdasilva perdasilva changed the title Add CLAUDE.MD 🌱 Add CLAUDE.MD Oct 17, 2025
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.93%. Comparing base (9eac616) to head (731e511).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2275   +/-   ##
=======================================
  Coverage   72.93%   72.93%           
=======================================
  Files          88       88           
  Lines        8743     8743           
=======================================
  Hits         6377     6377           
- Misses       1951     1952    +1     
+ Partials      415      414    -1     
Flag Coverage Δ
e2e 39.38% <ø> (ø)
experimental-e2e 46.72% <ø> (ø)
unit 58.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@perdasilva perdasilva closed this Oct 17, 2025
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is great.
But before we add it, what info here is valid only for upstream?

If we add this, will all be valid for downstream? I do not think so,
So, how will we have information for upstream and another for downstream?

/hold until we have this answer.

@joelanford @tmshort have you ideas?
What about we ignore those files in the sync/bumper?
Than it would get solved. But do we want to have the same for downstream specifics?

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2025
@perdasilva
Copy link
Contributor Author

@camilamacedo86 I've closed this in favor of the AGENTS.md file - I think that could be good for all agents

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants