Skip to content

Conversation

@perdasilva
Copy link
Contributor

Description

Adds a couple of unit tests to exercise the .spec.config.inline schema validation (specifically as it pertains to expecting whole json objects).

Note: we should also be able to inject valid yaml. However, this was not being accepted by the client in the test - it expected valid json. I'm not sure what we can do to add this test at this level =S

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@perdasilva perdasilva requested a review from a team as a code owner October 20, 2025 23:07
@openshift-ci openshift-ci bot requested review from anik120 and grokspawn October 20, 2025 23:07
@netlify
Copy link

netlify bot commented Oct 20, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 9a142bc
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/68f6c0be1a81cc0008186679
😎 Deploy Preview https://deploy-preview-2279--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2025
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.31%. Comparing base (f125d8b) to head (9a142bc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2279      +/-   ##
==========================================
+ Coverage   70.28%   70.31%   +0.03%     
==========================================
  Files          88       88              
  Lines        8762     8762              
==========================================
+ Hits         6158     6161       +3     
+ Misses       2190     2188       -2     
+ Partials      414      413       -1     
Flag Coverage Δ
e2e 45.16% <ø> (+0.03%) ⬆️
experimental-e2e 14.16% <ø> (ø)
unit 58.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ci
Copy link

openshift-ci bot commented Oct 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, pedjak, thetechnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 57345c8 into operator-framework:main Oct 21, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants