Skip to content

Conversation

@michaelryanpeter
Copy link
Contributor

Description

Helping @perdasilva by updating the docs strings for the API definitions.

🤞 I did this right :)

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@michaelryanpeter michaelryanpeter requested a review from a team as a code owner November 24, 2025 15:18
@netlify
Copy link

netlify bot commented Nov 24, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 91daf1f
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/69248a7105460700083c6f0b
😎 Deploy Preview https://deploy-preview-2359--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.42%. Comparing base (cd6bab6) to head (91daf1f).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2359      +/-   ##
==========================================
- Coverage   74.45%   74.42%   -0.03%     
==========================================
  Files          93       93              
  Lines        7300     7300              
==========================================
- Hits         5435     5433       -2     
- Misses       1433     1434       +1     
- Partials      432      433       +1     
Flag Coverage Δ
e2e 44.54% <ø> (ø)
experimental-e2e 48.75% <ø> (-0.04%) ⬇️
unit 58.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort
Copy link
Contributor

tmshort commented Nov 25, 2025

The CRD diff is only the text.

@tmshort
Copy link
Contributor

tmshort commented Nov 25, 2025

/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants