Skip to content

Conversation

@perdasilva
Copy link
Contributor

Description

Removes the Migrated reason from the ClusterExtensionRevision Available condition. It would be short-lived and it makes more sense to let the revision controller set the conditions. If there is need to call out migration, we could set an annotation on the revision resource.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Copilot AI review requested due to automatic review settings December 4, 2025 16:59
@perdasilva perdasilva requested a review from a team as a code owner December 4, 2025 16:59
@netlify
Copy link

netlify bot commented Dec 4, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 7643dc4
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6931bdef18f6e30008c14e04
😎 Deploy Preview https://deploy-preview-2374--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci
Copy link

openshift-ci bot commented Dec 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thetechnick for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot finished reviewing on behalf of perdasilva December 4, 2025 17:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the transient "Migrated" reason from the ClusterExtensionRevision Available condition during storage migration from Helm to ClusterExtensionRevision. The change simplifies the migration flow by allowing the revision controller to manage all condition states uniformly, rather than having the migrator set a short-lived condition.

  • Removed the ClusterExtensionRevisionReasonMigrated constant from the API types
  • Eliminated status condition update code in the migration flow that set Available=Unknown with reason "Migrated"
  • Simplified the BoxcutterStorageMigrator.Migrate() method by removing the post-creation status update logic

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
api/v1/clusterextensionrevision_types.go Removed the unused ClusterExtensionRevisionReasonMigrated constant from condition reasons
internal/operator-controller/applier/boxcutter.go Removed code that sets Available=Unknown status condition after creating a migrated revision, along with the subsequent status update and re-fetch operations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.81%. Comparing base (d44cbaf) to head (7643dc4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2374      +/-   ##
==========================================
+ Coverage   72.26%   74.81%   +2.55%     
==========================================
  Files          95       95              
  Lines        7336     7327       -9     
==========================================
+ Hits         5301     5482     +181     
+ Misses       1631     1410     -221     
- Partials      404      435      +31     
Flag Coverage Δ
e2e 44.91% <ø> (?)
experimental-e2e 49.33% <ø> (+<0.01%) ⬆️
unit 58.79% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant