Skip to content

Commit 4ed2a7e

Browse files
Merge pull request #945 from jpeeler/minor-fixes
Minor fixes
2 parents 18b6c0d + eefcdec commit 4ed2a7e

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

pkg/api/wrappers/deployment_install_client.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,7 @@ func (c *InstallStrategyDeploymentClientForNamespace) FindAnyDeploymentsMatching
123123

124124
func (c *InstallStrategyDeploymentClientForNamespace) FindAnyDeploymentsMatchingLabels(label labels.Selector) ([]*appsv1.Deployment, error) {
125125
deployments, err := c.opLister.AppsV1().DeploymentLister().Deployments(c.Namespace).List(label)
126-
// Any errors other than !exists are propagated up
127-
if err != nil && !apierrors.IsNotFound(err) {
126+
if err != nil {
128127
return nil, err
129128
}
130129

test/e2e/setup_bare_test.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,10 @@ import (
1313
"time"
1414

1515
"github.com/sirupsen/logrus"
16+
log "github.com/sirupsen/logrus"
1617
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
1718
utilclock "k8s.io/apimachinery/pkg/util/clock"
19+
"k8s.io/client-go/tools/clientcmd"
1820

1921
v1 "github.com/operator-framework/operator-lifecycle-manager/pkg/api/apis/operators/v1"
2022
"github.com/operator-framework/operator-lifecycle-manager/pkg/api/client"
@@ -73,6 +75,11 @@ func TestMain(m *testing.M) {
7375
ctx, cancel := context.WithCancel(signals.Context())
7476
defer cancel()
7577

78+
config, err := clientcmd.BuildConfigFromFlags("", *kubeConfigPath)
79+
if err != nil {
80+
log.Fatalf("error configuring client: %s", err.Error())
81+
}
82+
7683
// operator dependencies
7784
crClient, err := client.NewClient(*kubeConfigPath)
7885
if err != nil {
@@ -116,6 +123,7 @@ func TestMain(m *testing.M) {
116123
olm.WithResyncPeriod(time.Minute),
117124
olm.WithExternalClient(crClient),
118125
olm.WithOperatorClient(olmOpClient),
126+
olm.WithRestConfig(config),
119127
)
120128
if err != nil {
121129
logrus.WithError(err).Fatalf("error configuring olm")

0 commit comments

Comments
 (0)