-
Notifications
You must be signed in to change notification settings - Fork 566
[WIP] cache-fixes #3464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] cache-fixes #3464
Conversation
d1795f1 to
9036c7b
Compare
Signed-off-by: Per Goncalves da Silva <[email protected]>
9036c7b to
61a0e72
Compare
Signed-off-by: Per Goncalves da Silva <[email protected]>
ae0b265 to
39e8897
Compare
| }) | ||
| } | ||
|
|
||
| func (o *operator) ResyncInformers() error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No client using LIST + WATCH should ever have to do this, FWIW.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, watch events are at least once right?
This mishmash of cached and live requests is biting us in the butt....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case you're curious: the issue is we have a situation in which the namespaces gets nuked and immediately recreated with the subscription, and we're ending up with unsat...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you using UID checks to detect deletion + recreation? Do you care that it deleted & recreated, or no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the end the RC was: the typed queues were of any type and we were enqueuing two different types of objects (string and ResourceEvent). Two semantically equal events come in and get sync'ed concurrently because we break dedupe =P
|
Using a |
Signed-off-by: Per Goncalves da Silva <[email protected]>
Sorry - the PR description was misleading because I fumbled the commit (--amend). What I'm trying to understand is this: #3010 |
Description of the change:
Motivation for the change:
Architectural changes:
Testing remarks:
Reviewer Checklist
/doc[FLAKE]are truly flaky and have an issue