Skip to content

[WIP] Experimental/Refactor subscription reconciler away from kubestate #3467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[WIP] Experimental/Refactor subscription reconciler away from kubestate #3467

wants to merge 3 commits into from

Conversation

@perdasilva
Copy link
Collaborator

@perdasilva perdasilva commented Dec 16, 2024

Description of the change:

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2024
@perdasilva perdasilva changed the title [WIP] Experimenta/Refactor subscription reconciler away from kubestate [WIP] Experimental/Refactor subscription reconciler away from kubestate Dec 16, 2024
@perdasilva perdasilva force-pushed the perdasilva/cache-bug-fix branch 15 times, most recently from 5aeccb6 to 0102c1d Compare December 17, 2024 10:04
@perdasilva perdasilva force-pushed the perdasilva/cache-bug-fix branch from 0102c1d to 816b551 Compare December 17, 2024 10:48
just subscription sync changes
a6db0ef 
Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva force-pushed the perdasilva/cache-bug-fix branch from c0b639d to a6db0ef Compare December 17, 2024 12:10
e2e logs
29c2f81 
Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva force-pushed the perdasilva/cache-bug-fix branch from b04bce3 to 29c2f81 Compare December 17, 2024 13:37
@perdasilva perdasilva closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@benluddy benluddy Awaiting requested review from benluddy

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@perdasilva