Skip to content

Conversation

@bentito
Copy link
Contributor

@bentito bentito commented Dec 20, 2024

Description of the change:
Bumps go/net to v0.33.0

Motivation for the change:
Use latest go/net

Architectural changes:

none

Testing remarks:

Minor code changes were needed to accommodate the updated parsing.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

Signed-off-by: Brett Tofel <[email protected]>
@perdasilva
Copy link
Collaborator

closing as #3479 got merged

@perdasilva perdasilva closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants