Skip to content

Conversation

camilamacedo86
Copy link
Contributor

Description of the change:

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

go 1.23.0

toolchain go1.23.4
go 1.23.7
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grokspawn @tmshort
The operator-registry requires 1.23.7

go 1.23.0

toolchain go1.23.4
go 1.23.7
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grokspawn @tmshort
The operator-registry requires 1.23.7

@tmshort
Copy link
Contributor

tmshort commented Apr 28, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2025
@tmshort
Copy link
Contributor

tmshort commented Apr 28, 2025

For reasons, we can't update golang to 1.23.7.
I do wonder, if perhaps, on operator-registry, we require an older version of distribution/distribution/v3 and use a replace to get the latest? That way, maybe we can stick with golang 1.23.6? Not sure how that works when we pull it in, however.

@camilamacedo86
Copy link
Contributor Author

Clsoed in favor of " #3562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants