Skip to content

🌱 Add go-version check to avoid upgrade versions for those that we cannot support yet #3561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2025
Merged

🌱 Add go-version check to avoid upgrade versions for those that we cannot support yet #3561

merged 2 commits into from
Apr 30, 2025

Conversation

camilamacedo86
Copy link
Contributor

…

Description of the change:

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@camilamacedo86
Copy link
Contributor Author

c/c @tmshort @grokspawn

@openshift-ci openshift-ci bot requested review from dinhxuanvu and tmshort April 28, 2025 18:19
tmshort
tmshort previously approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2025
@grokspawn
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2025
@camilamacedo86 camilamacedo86 added this pull request to the merge queue Apr 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 29, 2025
perdasilva
perdasilva reviewed Apr 29, 2025
View reviewed changes
perdasilva
perdasilva requested changes Apr 29, 2025
View reviewed changes
Copy link
Collaborator

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may need to change the branch to master in the gha config

@camilamacedo86 @perdasilva
Update .github/workflows/go-verdiff.yaml
7e16e6c 
Co-authored-by: Per Goncalves da Silva <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2025
tmshort
tmshort approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2025
@perdasilva perdasilva added this pull request to the merge queue Apr 29, 2025
@camilamacedo86 camilamacedo86 removed this pull request from the merge queue due to a manual request Apr 29, 2025
@perdasilva perdasilva added this pull request to the merge queue Apr 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 30, 2025
@camilamacedo86 camilamacedo86 added this pull request to the merge queue Apr 30, 2025
Merged via the queue into operator-framework:master with commit 983e410 Apr 30, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perdasilva perdasilva perdasilva approved these changes

@tmshort tmshort tmshort approved these changes

@dinhxuanvu dinhxuanvu Awaiting requested review from dinhxuanvu

Assignees

@tmshort tmshort

@grokspawn grokspawn

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@camilamacedo86 @grokspawn @perdasilva @tmshort