only create cachedir if requested, since otherwise opm will error out serving it #3589
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Make cachedir creation contingent on a requested extractContent.cacheDir configuration.
Motivation for the change:
Otherwise, in-cluster opm will find an existing-but-empty cache directory in the filespace and will recognize it as a broken cache. This is correct, since it could be that the creator intended to put cache content in the destination, but forgot|failed to.
Architectural changes:
Testing remarks:
approach:
make run-local
opm render
to local fs (in a subdir $catdir)opm generate dockerfile -i scratch $catdir
to make a binless catsrc dockerfilequay.io/jordankeister/catalogs:cacheless
).status.image
, ..metadata.name
,spec.displayName
to make this catsrc uniquekubectl apply -f catsrc.yaml
Reviewer Checklist
/doc
[FLAKE]
are truly flaky and have an issue