Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
changes the default lifetime of registry cache content from 5m to 30m.
Motivation for the change:
Cache expiry requires new snapshots to be requested from catalogsources, and for combinations of short cache lifetime, # namespaces, and # subscriptions this resulted in a high rate of snapshot request.
This area in the code still suffers from (at least) two issues:
HOWEVER, this 6x reduction in frequency has been enough to make this problem disappear for all practical purposes, and can be pursued independently.
Architectural changes:
Testing remarks:
Reviewer Checklist
/doc
[FLAKE]
are truly flaky and have an issue