Skip to content

Conversation

joelanford
Copy link
Member

Description of the change:

Ensure that selectors are always in sorted order when generating aggregation rules for operator group cluster roles.

Motivation for the change:

Lack of deterministic order of selectors in aggregation rules causes unnecessary updates of cluster roles, which can cause significant performance issues within the Kubernetes control plane.

Architectural changes:

None

Testing remarks:

Unit tests added to avoid regressions

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot requested review from ankitathomas and tmshort June 9, 2025 20:10
@joelanford joelanford force-pushed the fix-og-aggregationrule-selector-order branch from fce8174 to 73bb54d Compare June 9, 2025 20:25
@joelanford joelanford changed the title OCPBUGS-57222: operatorgroup: ensure clusterroleselectors in clusterrole aggregation rules are sorted operatorgroup: ensure clusterroleselectors in clusterrole aggregation rules are sorted Jun 9, 2025
@joelanford joelanford added this pull request to the merge queue Jun 9, 2025
Merged via the queue into operator-framework:master with commit 3558fae Jun 9, 2025
13 checks passed
@joelanford joelanford deleted the fix-og-aggregationrule-selector-order branch June 11, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants